Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-year Plans Default Experiment: Ensure only the onboarding flow is eligible #98563

Merged

Conversation

jeyip
Copy link
Contributor

@jeyip jeyip commented Jan 18, 2025

Proposed Changes

  • Introduces changes to the useLongerPlanTermDefaultExperiment hook and adds an optional flowName parameter.
  • This parameter is used to ensure only the onboarding flow displays the multi-year plans by default experiment changes.

Why are these changes being made?

  • We only want to target /setup/onboarding/plans and /start/plans

Testing Instructions

  • Manually assign self to an experiment variant default_to_three_year_plans, default_to_two_year_plans, emphasize_savings_only 22092-explat-experiment
  • Visit /setup/onboarding/plans and verify that the savings emphasis badges and multi-year plan term defaults behave as expected
  • Visit a different flow, like /setup/newsletter/plans or /start/onboarding-pm/plans and verify that the savings emphasis badges and multi-year defaults aren't displayed

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jan 18, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~14 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
update-design-flow          +46 B  (+0.0%)      -14 B  (-0.0%)
plugins                     +46 B  (+0.0%)      -14 B  (-0.0%)
plans                       +46 B  (+0.0%)      -14 B  (-0.0%)
link-in-bio-tld-flow        +46 B  (+0.0%)      -14 B  (-0.0%)
jetpack-app                 +46 B  (+0.0%)      -14 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~9 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected        +47 B  (+0.0%)      -12 B  (-0.0%)
async-load-signup-steps-plans                          +47 B  (+0.0%)      -11 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jeyip jeyip self-assigned this Jan 18, 2025
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/emphasize_longer_plan_savings_experiment_eligibility on your sandbox.

@jeyip jeyip merged commit 7b2b622 into trunk Jan 18, 2025
13 checks passed
@jeyip jeyip deleted the update/emphasize_longer_plan_savings_experiment_eligibility branch January 18, 2025 02:18
@jeyip jeyip restored the update/emphasize_longer_plan_savings_experiment_eligibility branch January 18, 2025 02:18
@jeyip jeyip deleted the update/emphasize_longer_plan_savings_experiment_eligibility branch January 18, 2025 02:18
JessBoctor pushed a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants