-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribers: Add notice of how many subscribers were added, skipped, failed. #98562
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~501 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1509 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
94626fd
to
1fd969a
Compare
aa6a23c
to
8f41011
Compare
@@ -90,6 +91,7 @@ export const SubscribersPageProvider = ( { | |||
const [ showMigrateSubscribersModal, setShowMigrateSubscribersModal ] = useState( false ); | |||
const [ debouncedSearchTerm ] = useDebounce( searchTerm, 300 ); | |||
const { hasManySubscribers } = useManySubsSite( siteId ); | |||
const { completedJob } = useActiveJobRecognition( siteId ?? 0 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added completedJob
to return the data we get from the import endpoint response.
const { email_count, subscribed_count, already_subscribed_count, failed_subscribed_count } = | ||
completedJob; | ||
dispatch( | ||
successNotice( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message shows until dismissed.
Related to #97994
Proposed Changes
Why are these changes being made?
Testing Instructions
/subscribers/{site URL}
Note that if you import with categories, you'll get 0 already subscribed because we re-import with the correct categories.
Pre-merge Checklist