Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all flows to non reskinned ui #98561

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

ddc22
Copy link
Contributor

@ddc22 ddc22 commented Jan 17, 2025

Related to

Proposed Changes

  • Moves all signup flows to isReskinned
  • Opts out video press from all styling related to the reskinned flow.

Why are these changes being made?

  • The isReskinned flag has created unnecessary dependencies and complexity across the codebase, making it difficult to maintain and clean up. Migrating all signup flows to the reSkinned flavor will simplify the code, eliminate dead code, and reduce the risk of breakage in active flows when doing the final cleanup. Additionally, opting out Videopress from styling ensures its unique dark theme remains unaffected while benefiting from the updated UI structure.
  • Read More: pdvytD-V6-p2

Testing Instructions

Check the UIs on the screens below work well

  • Go to /start/crowdsignal, should have modern UI
  • Create a new site and go to :
    /start/launch-only/launch?siteSlug=launchonlytest1.wordpress.com
  • Go to /start/onboarding-registrationless
  • Go to /start/rewind-setup
  • Go to /start/__disabled_onboarding/initial-intent

And make sure look and feel is of the modern white signup UI

  • Go to /start/videopress-account and make sure everything remains unchanged.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ddc22 ddc22 changed the title Fix/cleanup and move to latest UI Move all flows to non reskinned ui Jan 17, 2025
client/signup/is-flow.ts Outdated Show resolved Hide resolved
@matticbot
Copy link
Contributor

matticbot commented Jan 17, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~103 bytes removed 📉 [gzipped])

name    parsed_size           gzip_size
signup       -580 B  (-0.2%)     -103 B  (-0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ddc22 ddc22 force-pushed the fix/cleanup-and-move-to-latest-ui branch from 5bf8574 to 8b10c85 Compare January 20, 2025 16:49
Comment on lines +96 to 97
if ( context.pathname.includes( 'videopress' ) ) {
addVideoPressSignupClassName();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep videopress class since that has a completely different theme.

@ddc22 ddc22 requested review from a team and southp January 20, 2025 18:26
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2025
@ddc22 ddc22 marked this pull request as ready for review January 20, 2025 18:27
@ddc22 ddc22 self-assigned this Jan 21, 2025
Copy link
Contributor

@oswian oswian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, nice cleanup!

@ddc22 ddc22 merged commit 2d30abd into trunk Jan 22, 2025
14 checks passed
@ddc22 ddc22 deleted the fix/cleanup-and-move-to-latest-ui branch January 22, 2025 02:44
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 22, 2025
JessBoctor pushed a commit that referenced this pull request Jan 22, 2025
* Cleanup and move to latest UI

* Handle videopress

* Cleanup

* Cleanup styling for videopress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants