-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all flows to non reskinned ui #98561
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~103 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
5bf8574
to
8b10c85
Compare
if ( context.pathname.includes( 'videopress' ) ) { | ||
addVideoPressSignupClassName(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep videopress class since that has a completely different theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well, nice cleanup!
* Cleanup and move to latest UI * Handle videopress * Cleanup * Cleanup styling for videopress
Related to
Proposed Changes
Why are these changes being made?
Testing Instructions
Check the UIs on the screens below work well
/start/crowdsignal
, should have modern UI/start/launch-only/launch?siteSlug=launchonlytest1.wordpress.com
/start/onboarding-registrationless
/start/rewind-setup
/start/__disabled_onboarding/initial-intent
And make sure look and feel is of the modern white signup UI
/start/videopress-account
and make sure everything remains unchanged.Pre-merge Checklist