Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receipts: Specify Automattic is the payment processor for membership receipts #98560

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

JessBoctor
Copy link
Collaborator

@JessBoctor JessBoctor commented Jan 17, 2025

Related to # 3426-gh-Automattic/payments-shilling
Dependent on 170345-ghe-Automattic/wpcom

Proposed Changes

  • This PR utilizes the service_slug passed from the transactions API and alters the string to payment processed by in the case of memberships

Why are these changes being made?

  • After deploying 2989-gh-Automattic/payments-shilling, it was pointed out that that having receipts for membership purchases show by Automattic is less than ideal.

Before:

gh3426-update-by-line

image

After:

gh3426-update-by-line-after Screenshot 2025-01-22 at 14 17 01

Testing Instructions

  • Apply 170345-ghe-Automattic/wpcom to your sandbox This has been merged to trunk
  • Apply this patch and start Calypso Local host
  • Visit a receipt with a membership purchase
  • Instead of seeing by Automattic, Inc under the service name, you should see Payment processed by Automattic, Inc

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@JessBoctor JessBoctor requested a review from a team as a code owner January 17, 2025 21:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 17, 2025
@matticbot
Copy link
Contributor

matticbot commented Jan 17, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~52 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases       +396 B  (+0.0%)      +52 B  (+0.0%)
purchases            +396 B  (+0.0%)      +52 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug gh3426/fix/update-receipt-byline on your sandbox.

@JessBoctor JessBoctor requested review from a team as code owners January 22, 2025 19:50
@JessBoctor JessBoctor added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jan 22, 2025
@JessBoctor JessBoctor force-pushed the gh3426/fix/update-receipt-byline branch from d6e2040 to f60bdd3 Compare January 22, 2025 20:02
@a8ci18n
Copy link

a8ci18n commented Jan 22, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17203710

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @JessBoctor for including a screenshot in the description! This is really helpful for our translators.

@sirbrillig sirbrillig removed request for a team January 22, 2025 21:17
Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JessBoctor JessBoctor self-assigned this Jan 23, 2025
@a8ci18n
Copy link

a8ci18n commented Jan 26, 2025

Translation for this Pull Request has now been finished.

@JessBoctor JessBoctor merged commit d73d080 into trunk Jan 31, 2025
14 checks passed
@JessBoctor JessBoctor deleted the gh3426/fix/update-receipt-byline branch January 31, 2025 20:19
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants