Goals First: Record selected goals for every step in the calypso_signup_step_start event

[vykes-mac]

Closes #98058

Proposed Changes

• add properties goals and is_goals_first to the calypso_signup_step_start event.

Why are these changes being made?

• To simply the data work since they rely on calypso_signup_step_start to track user progression in the signup funnel.

Testing Instructions

• Go to setup/onboarding
• Go through the flow and verify for each step selected goals and is_goals_first is recorded in the calypso_signup_step_start event.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129289

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129289&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-129289&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug goals-first/record-goals-for-each-step on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~43 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
onboarding-flow       +127 B  (+0.6%)      +43 B  (+0.6%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[alshakero]

Hi there! We can extend the track events in the flow itself without changing the Stepper framework. You can copy this logic but add another case for STEPPER_TRACKS_EVENT_SIGNUP_STEP_START

Unless I'm misunderstanding this change.

[vykes-mac]

Hi there! We can extend the track events in the flow itself without changing the Stepper framework. You can copy this logic but add another case for STEPPER_TRACKS_EVENT_SIGNUP_STEP_START

Unless I'm misunderstanding this change.

Thanks for the review @alshakero changes make sense. I have applied them.

[autumnfjeld]

Confirmed properties goals and is_goals_first to the calypso_signup_step_start event. for design-setup, user, domains, plans.

[autumnfjeld]

Noting that we could also add goals and is_goals_first to the calypso_signup_step_start event on step=launchpad. Can do in a separate issue.

[autumnfjeld]

Tracks and props firing as expected. #98104 (comment)