Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Update test to still pass with released versions of Gutenberg #90283

Merged
merged 1 commit into from
May 3, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented May 3, 2024

Proposed Changes

PR #90225 updated a test to pass in the run against the nightly Gutenberg release after WordPress/gutenberg#60632 changed some labels. Unfortunately that broke the runs against released versions of Gutenberg.

This adjusts the test to match both the old and new labels, with a TODO comment pointing out that it can be adjusted once that Gutenberg change is released to all the environments we test against.

Testing Instructions

  • yarn workspace wp-e2e-tests build && ATOMIC_VARIATION=default TEST_ON_ATOMIC=true JETPACK_TARGET=wpcom-deployment yarn workspace wp-e2e-tests test -- test/e2e/specs/editor/editor__page-basic-flow.ts
  • yarn workspace wp-e2e-tests build && GUTENBERG_EDGE=1 TEST_ON_ATOMIC=true yarn workspace wp-e2e-tests test -- test/e2e/specs/editor/editor__page-basic-flow.ts

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

PR #90225 updated a test to pass in the run against the nightly
Gutenberg release after WordPress/gutenberg#60632 changed some labels.
Unfortunately that broke the runs against released versions of
Gutenberg.

This adjusts the test to match both the old and new labels, with a TODO
comment pointing out that it can be adjusted once that Gutenberg change
is released to all the environments we test against.
@anomiex anomiex added the [Type] Bug When a feature is broken and / or not performing as intended label May 3, 2024
@anomiex anomiex requested review from olaseni and a team May 3, 2024 15:50
@anomiex anomiex self-assigned this May 3, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 3, 2024
@anomiex anomiex requested a review from ntsekouras May 3, 2024 15:50
Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On trunk, the first test fails and the second succeeds.

In this fix/e2e-change-link branch, both tests pass.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@anomiex anomiex merged commit f77230c into trunk May 3, 2024
15 of 16 checks passed
@anomiex anomiex deleted the fix/e2e-change-link branch May 3, 2024 16:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants