Update: Clear tracks data when logging out (#3269)

Automattic · Nov 4, 2024 · 00a9aa1 · 00a9aa1
1 parent 1b16b2d
commit 00a9aa1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## [v2.23.0]
+
+### Fixes
+
+- Properly clear analytics cookies on logout [#3269](https://github.com/Automattic/simplenote-electron/pull/3269)
+
 ## [v2.22.2]
 
 ### Enhancements

diff --git a/lib/boot.ts b/lib/boot.ts
@@ -16,21 +16,11 @@ const clearStorage = (): Promise<void> =>
     localStorage.removeItem('localQueue:note');
     localStorage.removeItem('localQueue:preferences');
     localStorage.removeItem('localQueue:tag');
+    localStorage.removeItem('simpleNote');
     localStorage.removeItem('stored_user');
     sessionStorage.clear();
     window.electron?.send('appStateUpdate', {});
 
-    const settings = localStorage.getItem('simpleNote');
-    if (settings) {
-      try {
-        const { accountName, ...otherSettings } = JSON.parse(settings);
-        localStorage.setItem('simpleNote', JSON.stringify(otherSettings));
-      } catch (e) {
-        // pass - we only care if we can successfully do this,
-        //        not if we fail to do it
-      }
-    }
-
     Promise.all([
       new Promise((resolve) => {
         const r = indexedDB.deleteDatabase('ghost');

diff --git a/lib/state/analytics/middleware.ts b/lib/state/analytics/middleware.ts
@@ -100,6 +100,7 @@ export const middleware: S.Middleware = (store) => {
         break;
       case 'LOGOUT':
         record('user_signed_out');
+        analytics.clearedIdentity();
         break;
       case 'OPEN_NOTE':
         record('list_note_opened');