MU WPCOM: Filter out the full-site-editing plugin from the active_plugins list if the plugin file doesn't exist (2nd try)

[arthur791004]

Related to p1737694462032909/1737565339.870709-slack-CRWCHQGUB, 169775-ghe-Automattic/wpcom

Proposed changes:

UPDATE

This is the 2nd try and the previous one, #41841, has been reverted by #41886 because of the error below. See p1739932956773779-slack-C4N88L95W

Uncaught TypeError: array_search(): Argument #2 ($haystack) must be of type array, string given

It should be fixed by c7e93ce. But, weirdly, I cannot reproduce this issue on my wpcom site as it gets an array instead of empty string 🫠

---

• The plugin full-site-editing was removed using the task API with the CLI command below. However, this caused an issue where the plugin is still listed in the active_plugins option. Therefore, this PR filters it out from active_plugins if the plugin file has already been removed.
  wp --skip-plugins --skip-themes plugin delete full-site-editing

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Go to your atomic site
• Install WordPress.com Editing Toolkit
• Run the following command to remove the plugin:
  wp --skip-plugins --skip-themes plugin delete full-site-editing
• Run the following command to check whether the full-site-editing plugin is still listed in the active_plugins option
  wp option get active_plugins
• Apply changes to your atomic site
• Run the above command again and the full-site-editing plugin should not be listed in the active_plugins option

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Choose a review path based on your changes:
   • A. Team Review: add the "[Status] Needs Team Review" label
     • For most changes, including minor cross-team impacts.
     • Example: Updating a team-specific component or a small change to a shared library.
   • B. Crew Review: add the "[Status] Needs Review" label
     • For significant changes to core functionality.
     • Example: Major updates to a shared library or complex features.
   • C. Both: Start with Team, then request Crew
     • For complex changes or when you need extra confidence.
     • Example: Refactor affecting multiple systems.
3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

---

Mu Wpcom plugin:

• Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Wpcomsh plugin:

• Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the feat/remove-fse-from-active-plugins branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin feat/remove-fse-from-active-plugins
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[jp-launch-control]

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php	0/223 (0.00%)	0.00%	1 ❤️‍🩹

1 file is newly checked for coverage.

File	Coverage
projects/packages/jetpack-mu-wpcom/src/features/wpcom-fse/wpcom-fse.php	0/11 (0.00%) 💔

Full summary · PHP report · JS report

_{Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .}

[taipeicoder]

LGTM

[arthur791004]

Tested the following code to see whether it works if the value is a string. Now it works successfully.

apply_filters('option_active_plugins', '');