-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My Jetpack: increase product card status contrast ratio #41877
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I only see the Needs Connection (or Needs Plan) status on my JN test site though if Jetpack isn't connected, otherwise it's the green Active status for all cards. Is it only the warning status that had the low contrast?
Yes. Thanks for testing! |
Proposed changes:
On the My Jetpack page, the color contrast ratio of the status element (against the white background) is 3:1, which is too low for a text that size according to the WCAG guidelines. It should be at least 4.5:1.
This PR fixes it by replacing the current color,
jp-yellow-40
, byjp-yellow-50
. For information, Color studio includes the contrast ratio against a white background.Other information:
Jetpack product discussion
See Epic: https://github.com/Automattic/vulcan/issues/710
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
/wp-admin/admin.php?page=my-jetpack
jp-yellow-50