Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Protection: Disable setting in Protect in unsupported environments #41830

Merged

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented Feb 15, 2025

Depends on #41829

Proposed changes:

  • When accountProtection.isSupported is false:
    • Disables the account protection toggle
    • Adds a warning notice explaining that the feature has been disabled at the system level.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-scan-team/issues/1678

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Test the account protection toggle in Jetpack Protect
  • Add define( 'DISABLE_JETPACK_ACCOUNT_PROTECTION', true ) to your wp-config.php file.
  • Validate the feature can no longer be enabled in Protect, and the warning notice is displayed.

Screenshots:

Screenshot 2025-02-15 at 6 00 06 PM

@nateweller nateweller added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 15, 2025
@nateweller nateweller requested review from dkmyta and a team February 15, 2025 20:47
@nateweller nateweller self-assigned this Feb 15, 2025
@github-actions github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Feb 15, 2025
Copy link
Contributor

github-actions bot commented Feb 15, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/packages/account-protection, projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 15, 2025
Copy link
Contributor

github-actions bot commented Feb 15, 2025

Code Coverage Summary

No summary data is avilable for parent commit 6478ee4, cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 6478ee4 is available.

Full summary · PHP report · JS report

@nateweller nateweller marked this pull request as ready for review February 15, 2025 21:27
@nateweller nateweller added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] In Progress labels Feb 15, 2025
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 15, 2025
Copy link
Contributor

@dkmyta dkmyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@dkmyta dkmyta mentioned this pull request Feb 16, 2025
3 tasks
Base automatically changed from add/account-protection-settings to add/account-protection February 16, 2025 17:50
Copy link
Contributor

github-actions bot commented Feb 16, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/account-protection-protect-unsupported-env branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/account-protection-protect-unsupported-env
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@dkmyta dkmyta merged commit 7ff6b18 into add/account-protection Feb 16, 2025
57 of 59 checks passed
@dkmyta dkmyta deleted the add/account-protection-protect-unsupported-env branch February 16, 2025 18:56
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Account Protection [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants