Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate views: Redesign notices #40901

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jan 8, 2025

Fixes Automattic/wp-calypso#98088

Proposed changes:

Improves the design and copy of the notices displayed to users participating in the "Remove duplicate views" experiment.

Before After
Screenshot 2025-01-08 at 18 16 51 Screenshot 2025-01-08 at 18 18 05
Screenshot 2025-01-08 at 18 17 09 Screenshot 2025-01-08 at 18 18 15
Screenshot 2025-01-08 at 18 17 19 Screenshot 2025-01-08 at 18 18 27
Screenshot 2025-01-08 at 18 17 30 Screenshot 2025-01-08 at 18 18 38
Screenshot 2025-01-08 at 18 17 40 Screenshot 2025-01-08 at 18 18 50
Screenshot 2025-01-08 at 18 17 49 Screenshot 2025-01-08 at 18 19 01

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply these changes to your site
  • Assign yourself to the treatment variant of the 22129-explat-experiment experiment
  • If you already dismissed these notices in the past, remove the dismissals by running this code:
wp shell --user=<YOUR_USERNAME> --url=<YOUR_SITE>
wp> update_user_option( get_current_user_id(), 'wpcom_removed_calypso_screen_dismissed_notices', array(), true );
  • Visit any of the enforced WP Admin views:
    • edit.php
    • edit.php?post_type=jetpack-portfolio
    • edit.php?post_type=jetpack-testimonial
    • edit-comments.php
    • edit-tags.php?taxonomy=category
    • edit-tags.php?taxonomy=post_tag
  • Make sure the new notice looks good

@mmtr mmtr self-assigned this Jan 8, 2025
@mmtr mmtr requested a review from a team January 8, 2025 17:24
@mmtr mmtr added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/remove-duplicate-views-notices branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/remove-duplicate-views-notices
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@mmtr mmtr changed the title Update/remove duplicate views notices Remove duplicate views: Redesign notices Jan 9, 2025
Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, and I think the wording and image change makes sense

@mmtr mmtr merged commit b51c3f3 into trunk Jan 9, 2025
57 checks passed
@mmtr mmtr deleted the update/remove-duplicate-views-notices branch January 9, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[mu wpcom Feature] Wpcom Admin Interface [Package] Jetpack mu wpcom WordPress.com Features [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicate views: Redesign welcome notices
2 participants