Mb/explicit #82
Open
Mb/explicit #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess there are issues remains with the simulation data. Since there is no conflict with current code. I would suggest we rebase and merge it first. |
|
Yes, also on my other machine everything works and passes all the tests now... but I do not understand the actual problem. Still, I think that the benefits of merging now (even without these four tests passing) outweigh the problems it will cause if we diverge too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished converting the
InputSets andInputclasses to the implicit detection of tag parameters (detector, target, ...).Also added more test to cover for new edge cases (not many though).