Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 to the test matrix #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add Python 3.13 to the test matrix #35

wants to merge 3 commits into from

Conversation

teutoburg
Copy link
Contributor

@teutoburg teutoburg commented Sep 30, 2024

The Python version corresponding to Donald Duck's license plate will drop tomorrow 🚀

@teutoburg teutoburg self-assigned this Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a36cb40) to head (ef219d7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines            7         7           
=========================================
  Hits             7         7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugobuddel
Copy link
Contributor

Do we want to also add free-threaded Python to the CI? I believe this 3.13 will by with GIL. E.g. https://github.com/deadsnakes/action seems to be a way that we can already enable GILless right now

@teutoburg
Copy link
Contributor Author

@hugobuddel
Copy link
Contributor

Aaand it's delayed by a week: https://blog.python.org/2024/10/python-3130-release-candidate-3-released.html

They also say

We strongly encourage maintainers of Python projects to prepare their projects for 3.13 compatibilities during this phase, and where necessary publish Python 3.13 wheels on PyPI to be ready for the final release of 3.13.0.

So would be fine with me if we add the prerelease to matrix. Maybe we should have 'the next prerelease' in a test anyway so we don't have to suddenly solve bugs. But well it is also okay to stay behind.

.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/updated_tests.yml Show resolved Hide resolved
.github/workflows/webtests.yml Show resolved Hide resolved
@teutoburg teutoburg changed the title Add Python 3.13 to the test matrix Add Python ~3.13~ 3.13.0-rc.2 to the test matrix Oct 2, 2024
@teutoburg teutoburg changed the title Add Python ~3.13~ 3.13.0-rc.2 to the test matrix Add Python 3.13.0-rc.2 to the test matrix Oct 2, 2024
@teutoburg teutoburg marked this pull request as ready for review October 2, 2024 11:33
@teutoburg
Copy link
Contributor Author

Meh, Windoof no worky 🙄

@teutoburg teutoburg changed the title Add Python 3.13.0-rc.2 to the test matrix Add Python 3.13 to the test matrix Oct 7, 2024
@teutoburg
Copy link
Contributor Author

Hmm, now 3.13 is finally out (and supported by the action) and yet it's still failing on Windows. Not sure what's going on...

@hugobuddel
Copy link
Contributor

AlbedoBase_XL_Windows_fatal_exception_access_violation_3
"Windows fatal exception access violation" according to Leonardo.AI

This also resulted in pluggy being bumped from 1.3.0 to 1.5.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants