Skip to content

Commit

Permalink
Merge pull request #37 from AshleighAdams/packaging-bug
Browse files Browse the repository at this point in the history
Allow overriding Verlite.CLI's target framework.
  • Loading branch information
AshleighAdams authored Aug 12, 2021
2 parents afce568 + 20e74d7 commit 2e526e1
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 2 deletions.
3 changes: 2 additions & 1 deletion src/Verlite.CLI/Verlite.CLI.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp2.1</TargetFramework>
<TargetFrameworks>netcoreapp2.1;net5.0;</TargetFrameworks>
<OutputType>Exe</OutputType>
<PackAsTool>true</PackAsTool>
<ToolCommandName>verlite</ToolCommandName>
Expand Down
2 changes: 1 addition & 1 deletion src/Verlite.Core/Verlite.Core.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<Description>Core primitives and logic for automatic versioning via Git tags.</Description>
<RootNamespace>Verlite</RootNamespace>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions tests/IntegrationTests/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -euo pipefail
cd "$(dirname $0)"

export VERBOSE=""
export REPO_PATH="$(git rev-parse --show-toplevel)"

# setup the packages as version 0.0.0
export NUGET_PACKAGES="$(mktemp -d)"
Expand Down Expand Up @@ -59,5 +60,6 @@ test branch-follows-first-parent
test msbuild
test multiple-tags-on-same-commit
test auto-fetch
test publish-different-framework

echo "All complete."
28 changes: 28 additions & 0 deletions tests/IntegrationTests/tests/publish-different-framework.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#!/bin/bash
set -euo pipefail

git clone "$REPO_PATH" verlite > /dev/null 2> /dev/null

dotnet publish \
verlite/src/Verlite.CLI/Verlite.CLI.csproj \
-o artifacts \
-p:TargetFramework=net5.0 \
-p:PackAsTool=false \
> /dev/null 2> /dev/null

dotnet publish \
verlite/src/Verlite.CLI/Verlite.CLI.csproj \
-o artifacts2 \
-f=net5.0 \
-p:PackAsTool=false \
> /dev/null 2> /dev/null

should-exist() {
if [[ ! -f "$1" ]]; then
echo "Missing artifact: $1"
exit 1
fi
}

should-exist artifacts/Verlite.CLI.dll
should-exist artifacts2/Verlite.CLI.dll

0 comments on commit 2e526e1

Please sign in to comment.