Update MavFTP code, add MavFTPfs example/tool #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
force-pushed
the
mavftp_updates
branch
from
fc9ae70 to
467b904
Compare
|
@peterbarker I need to run pylint localy to make sure it is still 100% clean (no regressions) In hindsight it was a bad idea to reject pylint github workflow. I will create a new PR that adds a pylint workflow for just these and any other pylint clean files. Nice work @Williangalvani, really like the way you structured the OP and return enums. |
Williangalvani
force-pushed
the
mavftp_updates
branch
from
377307f to
dc0f2c4
Compare
tridge
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mounts mavftp as a virtual filesystem, which allows for more "human" interfacing with it.
There are caveats. It is obviously slower than doing things on your own machine. but this does allow interfacing using any filebrowser, for instance.
So far the filesystem is mounted as read-only. as there's no mavftp interface to write to a sector of a file, we'd have to create an abstraction layer that caches the whole file...
Screencast.from.2024-09-17.12-21-47.webm