Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mavgen WLua: Add param units to display #856

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

shancock884
Copy link
Contributor

The idea of this pull request is to add the field unit to the Wireshark display, whenever units are specified in the Mavlink dialect XML file. For example, output is as shown below, where the text such as "[us]", "[degE7]", etc is new:

Payload: GPS_RAW_INT (24)
    time_usec (uint64_t) [us]: 3625540000
    fix_type (GPS_FIX_TYPE): GPS_FIX_TYPE_3D_FIX (3)
    lat (int32_t) [degE7]: 514783466
    lon (int32_t) [degE7]: -25922214
    alt (int32_t) [mm]: 56900
    eph (uint16_t): 100
    epv (uint16_t): 100
    vel (uint16_t) [cm/s]: 0
    cog (uint16_t) [cdeg]: 0
    satellites_visible (uint8_t): 16
    alt_ellipsoid (int32_t) [mm]: 0
    h_acc (uint32_t) [mm]: 1000
    v_acc (uint32_t) [mm]: 1000
    vel_acc (uint32_t) [mm]: 200
    hdg_acc (uint32_t) [degE5]: 0
    yaw (uint16_t) [cdeg]: 0

Code lines changed is quite small, and I have done a number of manual checks on the output, but let me know if I need to do more...

@peterbarker
Copy link
Contributor

You might have a look at the python fucntion dump_message_verbose method for other interesting information you could emit

@peterbarker peterbarker merged commit 6996afc into ArduPilot:master Dec 14, 2023
11 checks passed
@shancock884
Copy link
Contributor Author

@peterbarker thanks for merging and your suggestion - I will take a look at that Python function.
I had a couple of thoughts of useful things to add, which I didn't get round to yet, so will x-check before doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants