DFReader: change to python3 only #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes the parser about 17% faster in loading a bin log
peterbarker
approved these changes
Jan 28, 2025
Comment on lines
+1092
to
+1094
| offsets = [] | ||
| counts = [] | ||
| formats = self.formats |
There was a problem hiding this comment.
This would not seem to be related to the PR title?
I mean, probably not a bad change, but...
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env python | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
So this doesn't reeally accomplish much, as DFReader is usually called from mavlogdump.py via mavutil.py.
We should probably change mavlogdump.py's shebang line as part of this PR.
|
@peterbarker added change to py3 shebang for a tools/examples/modules |
Nothing exceeds like excess :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can drop py2 support now
overall performance improvement of about 30% in loading a bin log
for release, we should make it 2.5.0