AP_Proximity: LD19/LD06 data length sanity check fix #29375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @boa-pe, thanks for this. one small thing, could you modify the commit title to start with "AP_Rangefinder: "? We do this because it makes backporting easier because we can immediately see which subsystem a change affects. To be clear I mean the commit title, not the PR title. thanks! |
boa-pe
changed the title
boa-pe
force-pushed
the
bugfix/ld19_sanity_check_fix
branch
2 times, most recently
from
3d70595 to
bb4c3c4
Compare
Hmmm.... Shouldn't that be AP_Proximity? |
boa-pe
force-pushed
the
bugfix/ld19_sanity_check_fix
branch
from
bb4c3c4 to
e381273
Compare
Yes, it definitely should be :-) |
|
oops :-) |
Signed-off-by: Adam Borowski <[email protected]>
peterbarker
force-pushed
the
bugfix/ld19_sanity_check_fix
branch
from
e381273 to
3f71876
Compare
peterbarker
approved these changes
Feb 26, 2025
peterbarker
changed the title
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AP_Rangefinder: LD19/LD06 data length sanity check fix
root cause: number of data points in frame stored only on 5bits. value been used without proper bitmask
to sanity check number of datapoints in frame