Scripted CRSF Menus #29368
Open
Scripted CRSF Menus #29368
+969
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add CRSF menu example add scripted CRSF menu events custom CRSFMenu helpers play Beethoven's 5th on CRSF command use native packed strings for CRSF menus and payloads support CRSF submenus
scripted menu event processing encoding for parameter entries propagated payload length in processing frames and use it in scripting support CRSF submenus refactor parameter read and write so that custom responses can be sent ensure parameter write responses do not override parameter metadata
andyp1per
force-pushed
the
pr-crsf-menu-script
branch
from
f48663e to
01785fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work kindly sponsored by Team Black Sheep and FOSS UAV
This PR adds the ability to create arbitrary custom menus in CRSF using lua scripting. This allows arbitrary scripted commands, including with user feedback, to be driven by transmitter menu interactions without requiring any additional installation on the transmitter. It opens up the possibility of allowing people to add arbitrary menus to individual lua scripts that can be the used easily from a transmitter. (I think this is quite a usability win fyi @rmackay9).
As much of the encoding as possible is done in lua to avoid the additional flash cost, but the menu structure itself still needs to be help in C++ in order to work correctly and efficiently.
An example menu can be seen in libraries/AP_Scripting/examples/crsf-menu.lua
and the output can be seen below.