Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Potential Vulnerability in Cloned Function #29366

Closed
wants to merge 1 commit into from

Conversation

tabudz
Copy link

@tabudz tabudz commented Feb 24, 2025

Description
This PR fixes a security vulnerability in singlevar() that was cloned from lua but did not receive the security patch. The original issue was reported and fixed under lua/lua@1f3c6f4.
This PR applies the same patch to eliminate the vulnerability.

References
https://nvd.nist.gov/vuln/detail/CVE-2022-28805
lua/lua@1f3c6f4

@tpwrules
Copy link
Contributor

We are still on Lua 5.3.6. It does not have the <const> feature and the CVE indicates it is not vulnerable.

Do you have reason to suspect this will affect us?

@tabudz
Copy link
Author

tabudz commented Feb 24, 2025

I ran a code clone detection tool and found that this function might be a clone of a vulnerable one in my database. Just wanted to give you a heads-up. If you're confident that your case isn't vulnerable, then it likely isn't. Thanks for the clarification! Closed the PR.

@IamPete1
Copy link
Member

Thanks for the report, were safe on 5.3 for now.

@IamPete1 IamPete1 closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants