Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpeedyBee F405 AIO #29329

Merged
merged 2 commits into from
Feb 27, 2025
Merged

SpeedyBee F405 AIO #29329

merged 2 commits into from
Feb 27, 2025

Conversation

andyp1per
Copy link
Collaborator

@andyp1per andyp1per commented Feb 19, 2025 •
edited
Loading

@andyp1per andyp1per force-pushed the pr-speedybeef405-aio branch from 25fcf20 to 9cd9105 Compare February 20, 2025 09:46
@andyp1per andyp1per requested a review from Hwurzburg February 20, 2025 09:47
Hwurzburg
Hwurzburg requested changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a better pinout image that has all the pin names designated, not just A,B,etc

@andyp1per andyp1per force-pushed the pr-speedybeef405-aio branch from 83f8e33 to cee618b Compare February 24, 2025 20:43
@andyp1per
Copy link
Collaborator Author

Hey @Hwurzburg it would be helpful if you could write a canonical README that we can just copy. These changes feel pretty arbitrary and are different to changes you have requested on other PR's - so maybe if you can produce a README that you consider perfect we can then avoid this back and forth 😄

@Hwurzburg
Copy link
Collaborator

Hwurzburg commented Feb 24, 2025 •
edited
Loading

unfortunately every board is a bit different....F4s are different than H7s in their RC sections, and this F4 is even more different...I try to make changes so I don't have to do them when its time to create a wiki page and have to re-review the pinouts and hwdef...we could discuss what you think on this one is arbitrary...most are obvious errors and omissions....

@andyp1per andyp1per force-pushed the pr-speedybeef405-aio branch from d5efb17 to ca6e767 Compare February 25, 2025 21:34
@andyp1per andyp1per requested a review from Hwurzburg February 25, 2025 21:35
@tridge
Copy link
Contributor

tridge commented Feb 26, 2025

@Hwurzburg can you re-check?

@Hwurzburg Hwurzburg force-pushed the pr-speedybeef405-aio branch from ca6e767 to 63ce9cf Compare February 26, 2025 13:14
@Hwurzburg
Copy link
Collaborator

I found a proper image and researched the S pin that I requested info on which apparently wont work since the code for its use is not included in our firmware and updated the readme and image

@peterbarker peterbarker merged commit bfa40f7 into ArduPilot:master Feb 27, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hwurzburg Hwurzburg Hwurzburg approved these changes

Assignees
No one assigned
Labels
ChibiOS NewBoardSupport WikiNeeded needs wiki update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andyp1per @Hwurzburg @tridge @CraigElder @peterbarker