GCS_MAVLink: simplify MissionItemProtocol get_item interface #29223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
reviewed
Feb 5, 2025
| mavlink_mission_item_int_t ret_packet; | ||
| const MAV_MISSION_RESULT result_code = get_item(_link, msg, packet, ret_packet); | ||
| const MAV_MISSION_RESULT result_code = get_item(packet.seq, ret_packet); |
There was a problem hiding this comment.
possible can avoid item_exists() and check return code from get_item()
There was a problem hiding this comment.
Done.
Saved 8 or 16 bytes...
Board AP_Periph blimp bootloader copter heli iofirmware plane rover sub
CubeOrange-periph-heavy 88 *
CubeRedPrimary 8 * 16 16 16 16 8
Durandal 8 * 8 8 8 8 8
Hitec-Airspeed * *
KakuteH7-bdshot 16 * 8 8 16 8 8
MatekF405 8 * 8 16 16 16 8
Pixhawk1-1M-bdshot 8 8 16 16 16 8
f103-QiotekPeriph * *
f303-Universal * *
iomcu *
revo-mini 16 * 16 8 16 16 16
skyviper-journey 16
skyviper-v2450 16
peterbarker
force-pushed
the
pr/missionitemprotocol-get-item-simpler
branch
from
1eb7079 to
d3d4ea5
Compare
stop passing through _link and the original msg, move use to the base class instead. starts fence and rally also using the "correct the GCS's count" code. This also corrects the error code when correcting the GCS's count to INVALID_SEQUENCE rather than just ERROR
peterbarker
force-pushed
the
pr/missionitemprotocol-get-item-simpler
branch
from
d3d4ea5 to
4550ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop passing through _link and the original msg, move use to the base class instead.
starts fence and rally also using the "correct the GCS's count" code.
This also corrects the error code when correcting the GCS's count to INVALID_SEQUENCE rather than just ERROR
This should allow for cleanups in the AP_Filesystem_Mission code in the future.