AP_AIS: fix multi part message decoding #29195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
force-pushed
the
AIS_multi_part
branch
3 times, most recently
from
5b68e96 to
9cd01d3
Compare
|
Needs a rebase... |
IamPete1
force-pushed
the
AIS_multi_part
branch
from
9cd01d3 to
c222d04
Compare
Done, kinda reassuring that the compiler could see the bug you found once it was possible to hit it. |
peterbarker
approved these changes
Feb 3, 2025
| uint8_t msg_parts[_incoming.num - 1]; | ||
|
|
||
| // We have the last part, need to find preceding fragments | ||
| const uint8_t parts = _incoming.num - 1; |
There was a problem hiding this comment.
There appears to be an integer underflow problem here; _incoming.num is coming off the wire, and nothing is checking if it is zero or not.
This is pre-existing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug meant we never re-assembled multi part messages correctly. Tested with the simulator.