Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_Networking: make connector loopback test priority to be PRIORITY_IO-1 #28410

Merged

Conversation

bugobliterator
Copy link
Member

No description provided.

@bugobliterator bugobliterator force-pushed the pr-reduce-loopback-test-prio branch from 1073fab to 70565d0 Compare October 16, 2024 02:25
@magicrub
Copy link
Contributor

This thread is faster so it makes sense but I'm not sure amount will change. Do you have any metrics to show that this makes any difference?

@bugobliterator
Copy link
Member Author

This thread is faster so it makes sense but I'm not sure amount will change. Do you have any metrics to show that this makes any difference?

We need this for Testing the modules. Lua scripts don't run properly until we set priority higher than loopback test thread.

@bugobliterator bugobliterator requested a review from tridge October 17, 2024 05:39
@tridge
Copy link
Contributor

tridge commented Nov 1, 2024

Maybe just set lua thread priority higher with the parameter for that?

@bugobliterator
Copy link
Member Author

Maybe just set lua thread priority higher with the parameter for that?

I think the loopback test needs to be lower than IO anyways. It completely chokes out all the remaining threads. As with loopback its just pushing and receiving data at a really high rate.

@tridge tridge merged commit bd7bb59 into ArduPilot:master Nov 20, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants