Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITL: FlightAxis Improvements #28282

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

robertlong13
Copy link
Collaborator

Adds a new options parameter for the FlightAxis SITL frame:

  • Option to automatically reset the aircraft position in RealFlight!!
  • Move the existing framestring-passed options to option bits (but keep the existing framestring parsing for now)
  • Option to silence the FPS reporting printf

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Oct 2, 2024
libraries/SITL/SIM_FlightAxis.h Outdated Show resolved Hide resolved
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge after these changes

libraries/SITL/SITL.cpp Outdated Show resolved Hide resolved
libraries/SITL/SIM_FlightAxis.h Outdated Show resolved Hide resolved
@timtuxworth
Copy link
Contributor

It makes sense to not call it FlightAxis - RealFlight stopped calling it that in (I think) Evolution.

@robertlong13
Copy link
Collaborator Author

It makes sense to not call it FlightAxis - RealFlight stopped calling it that in (I think) Evolution.

Agreed. It's an unfortunate historical holdover that we should fix in a future PR. That said, the param name we should go ahead and set correctly now.

@robertlong13 robertlong13 force-pushed the pr/flightaxis_improvements branch from 5136ef8 to 0556889 Compare October 16, 2024 06:31
@peterbarker peterbarker merged commit 61593e2 into ArduPilot:master Oct 25, 2024
98 checks passed
@robustini
Copy link
Contributor

robustini commented Nov 24, 2024

@robertlong13 sorry to comment here that a merge has already been done, but since even before the 4.5.7 release I have been noticing problems with Flightaxis and Realflight.
Never seen this behavior before: moving RC4 with the joystick I also have a shift of about 100 uS up and down of CH8.
Having assigned CH8 to the flight modes so moving the directional also changes my flight modes, and it is not nice.
Obviously on the controller panel of Realflight this thing by moving that channel does not happen, so I think it is attributable to flight axis.
No active mixing in TX, in fact in Realflight without Flighaxis the rudder CH4 channel does not interfere with the one on CH8.

@robertlong13 robertlong13 deleted the pr/flightaxis_improvements branch November 24, 2024 22:25
@robertlong13
Copy link
Collaborator Author

@robustini, it's extremely unlikely that this has anything to do with this PR, but I can probably help. We should take this conversation to Discord though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants