Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Expose DDS build options in build_options.py #28159

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Tools: Expose DDS build options in build_options.py #28159

wants to merge 1 commit into from
+7 −0

Conversation

Ryanf55
Copy link
Collaborator

@Ryanf55 Ryanf55 commented Sep 20, 2024

As requested by @peterbarker - should we create the networking options, and if so, how should we deconflict the existing CLI options?

@Ryanf55 Ryanf55 requested a review from peterbarker September 21, 2024 01:55
@Ryanf55 Ryanf55 added the ROS label Sep 21, 2024
@Ryanf55 Ryanf55 added this to the DDS 4.6 milestone Sep 21, 2024
@tridge tridge force-pushed the dds-expose-options-in-build-options-py branch from 2629cbd to 6d9a754 Compare October 7, 2024 23:42
tridge
tridge requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs extract_features.py update

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Oct 7, 2024

Remove the original --enable-dds from waf.

@Ryanf55
Copy link
Collaborator Author

Ryanf55 commented Oct 8, 2024 •
edited
Loading

For testing:

  • ./Tools/autotest/test_build_options.py --define-match-glob "*_DDS_*"

@Ryanf55 Ryanf55 force-pushed the dds-expose-options-in-build-options-py branch from 6d9a754 to d151a88 Compare October 19, 2024 15:54
@Ryanf55 Ryanf55 mentioned this pull request Oct 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge requested changes

@peterbarker peterbarker Awaiting requested review from peterbarker

Assignees
No one assigned
Labels
ROS
Projects
DDS/ROS2
Status: No status
Milestone
DDS 4.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Ryanf55 @tridge @CraigElder