-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Airspeed: ND210 pressure sensor, airspeed library #26859
base: master
Are you sure you want to change the base?
Conversation
Hi @zzaurak, Thanks for this. Just a small admin thing, it would be good to change the commit title (not the PR title but the individual commit titles) to start with "AP_Airspeed: ". |
8088a65
to
b78b8cc
Compare
Hi @rmackay9 thanks for the feedback, I changed the commit titles :) |
4de9f82
to
a48f40e
Compare
As promised I did a real-world comparison test flight with the ND210 airspeed sensor and this PR. I've attached the log 00000028-anon.log.zip. ASPD[0] is the DLVR I would say pretty much comparable, but especially in the lower speed ranges and while in QLoiter and FBWA it looks a bit smoother. |
a48f40e
to
8ae6f35
Compare
@rmackay9 anything else that would be blocking a merge? |
081fc23
to
5a380be
Compare
5a380be
to
a71dc45
Compare
a71dc45
to
b6cb9bc
Compare
28d7dc0
to
8eb075d
Compare
adding ND210 Airspeed library Tuning ND210 refactored _send_configuration_command and renamed member variables Cleaning up printouts. Changing cast to uint.
64e60e7
to
fa9fbac
Compare
& some fixes after rebase
fa9fbac
to
f5ad926
Compare
I've rebased this pull request #23300, did some fixes and testet it with real hardware. It seems to work well on the bench, I will do a few real word flight test & comparisons next week and report as well.