-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_JSON: added JSON parsing library #26114
Conversation
3141e70
to
067377e
Compare
This could be good for integration with various AI systems that all seem to use JSON.. |
I'd expect those to use a json implementation in lua (JSON is very easy in lua) |
215a428
to
5795a7e
Compare
c9a1b9b
to
e7604c1
Compare
Tools/ardupilotwaf/chibios.py
Outdated
# we use string find on these symbols, so this catches all types of throw calls | ||
blacklist = ['std::__throw'] | ||
|
||
print("COMMAND: %s -C %s" % (task.env.get_flat('NM'), elfpath)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this print() should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me once you explained the gmtime->gmtime_r changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good so long as the Callisto model works on SITL-on-hardware.
Take a look at the benefit of At compile time, you can get an error when trying to access values out of range. Peter proposes doing a trivial example of changing a raw array to I would recommend enabling this in SITL when SITL is in debug mode. Coupled with using |
the ABI change warnings for gcc 7.1 are not useful
using gmtime_r makes gmtime thread safe
using gmtime_r makes gmtime thread safe
using gmtime_r makes gmtime thread safe
using gmtime_r makes gmtime thread safe
using gmtime_r makes gmtime thread safe
using gmtime_r makes gmtime thread safe
this cleans up our blacklist of library functions, and ensures there can be no accidential use of std:: functions that cause exceptions in flight code on HAL_ChibiOS
if scripting can't find an error handler it can call abort(). We don't ever want to do that in ArduPilot
This is an alternative to #23673 that adds AP_JSON based on a re-working of picojson. It runs on both SITL and HAL_ChibiOS
I think this provides a nicer JSON API which is better for future usage of JSON