-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move AP_Scripting object up to AP_Vehicle #26097
Conversation
|
This means that scripting now comes up before a bunch of other stuff? What happens if my script needs some of that for its first run? For example it looks like on copter scripting now comes before attitude control and motors. We have singletons for those, so will a script error out on its first run? They can dump you in config error loops also, I wonder what happens to the script in that case. I think my preference would be to just move scripting to be the last thing init. It means were less likely to hit issues with this change, or in the future if we add more things after where this PR moves it to. I can't immediately think of an problem that would result from having the script come up after stuff its currently before. |
2076e72
to
314f60b
Compare
I've moved it. |
314f60b
to
cadc490
Compare
... I've also done a smoke test to make sure hello_world.lua works on real hardware. |
Setup for testing was this for each vehicle:
... then making sure those parameter values were still present on the new firmware.