Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix frame index issue + no more outframes_dir #65

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

Firepal
Copy link
Collaborator

@Firepal Firepal commented Apr 10, 2023

In response to #62:

  • The "+1" used for compensating for frame filenames is now in VideoHandlerDisk instead of build_output_video
  • Frame index assert now reports more information
  • Removed the "outframes" directory mechanism, now STAMMER pipes frames directly to ffmpeg for video encoding

@onedez
Copy link

onedez commented Apr 10, 2023

Ooh! Ooh! I updated my stammer directory with the changes in this fork and it solved my problem! It works now! Thank you! :D

@Firepal
Copy link
Collaborator Author

Firepal commented Apr 10, 2023

@Hmlerr This is wonderful news! I don't have enough hard drive space to test this with a big movie, so thank you for testing.
Now we wait for @ArdenButterfield's input. :]

@onedez
Copy link

onedez commented Apr 10, 2023

@Firepal Here are some videos I created using it. hehehe :D
https://youtu.be/Ff9_v-UE6xY
https://youtu.be/aMPRJaqZf1A

@ArdenButterfield
Copy link
Owner

This is excellent! Thank you so much, @Firepal. And @Hmlerr , your videos are hilarious.

@ArdenButterfield ArdenButterfield merged commit adb2671 into ArdenButterfield:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants