Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minor version to prepare release #316

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

christian-rauch
Copy link
Collaborator

@christian-rauch christian-rauch commented Feb 4, 2024

The last release was more than 1 year ago and many performance and compilation improvements have been committed since then. Let's create a new release for this.

The most notable breaking changes are the removal of the Makefile, some changes in the Python bindings installation path and the removal of unused parameters in some public functions which will break API if they are used directly.

I intend to use this release to create new binary package releases for the ROS repo and conda-forge.

Copy link
Collaborator

@wxmerkt wxmerkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing this. Can you please update the CHANGELOG. Did you check that the Python install path change doesn't break on ROS1 if it's used there?

@christian-rauch
Copy link
Collaborator Author

Do you mean a specific CHANGELOG file? I couldn't find such a file in the repo. I would add those notes to the release notes on the GitHub release page.

Regarding the Python bindings, they were never built and installed for the ROS package. Only since #311 are we specifying the Python dependencies for the ROS package. The ROS package that will be released for 3.4 will install those Python bindings to /opt/ros/humble/lib/python3.10/site-packages/apriltag.cpython-310-x86_64-linux-gnu.so. I tested this with the ros-deb-builder-action.

@christian-rauch christian-rauch merged commit 77a769a into AprilRobotics:master Mar 10, 2024
19 checks passed
@christian-rauch christian-rauch deleted the rel_34 branch March 10, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants