Fixed non-used code, bugs (specifically ReportLandlordTen.php), as we…

…ll as minor/major severity issues on scrutinizer.

boost/boost.php

@@ -12,4 +12,4 @@
 $image_dir    = false;
 $file_dir     = false;
 
-?>
+ 

boost/controlpanel.php

@@ -31,4 +31,4 @@
         'tab'           => 'content'
         );
 
-?>
+ 

boost/dependency.xml

@@ -1,4 +1,4 @@
-<?xml version="1.0"?>
+<?xml version="1.0" 
 <dependency>
   <module>
     <title>core</title>

boost/update.php

@@ -144,4 +144,4 @@ function slcUpdateFiles($files, &$content) {
     $content[] = "    " . implode("\n    ", $files);
 }
 
-?>
+ 

build.xml

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?>
+<?xml version="1.0" encoding="UTF-8" 
 
 <project name="slc" default="build">
     <property environment="env" />

class/AJAXFactory.php

@@ -51,4 +51,4 @@ public function result() {
 
 }
 
-?>
+ 

class/Client.php

@@ -128,4 +128,4 @@ public function setReferralString($referralString)
 	}
 }
 
-?>
+ 

class/ClientDB.php

@@ -6,4 +6,4 @@ class ClientDB extends Client {
 	public function __construct(){}
 }
 
-?>
+ 

class/CommandContext.php

@@ -66,4 +66,4 @@ function redirect($request){
     }
 }
 
-?>
+ 

class/Issue.php

@@ -124,4 +124,4 @@ public function setLandlordName($lName)
 	}
 }
 
-?>
+ 

class/ViewFactory.php

@@ -36,4 +36,4 @@ public static function getView($view = 'Main'){
     }
 }
 
-?>
+ 

class/Visit.php

@@ -51,4 +51,4 @@ public function getClientId()
 	}
 }
 
-?>
+ 

class/VisitDB.php

@@ -6,4 +6,4 @@ class VisitDB extends Visit {
 	public function __construct(){}
 }
 
-?>
+ 

class/ajax/AJAX.php

@@ -23,4 +23,4 @@ protected function addResult($r, $v) {
 	}
 }
 
-?>
+ 

class/ajax/ClientFactory.php

@@ -90,4 +90,4 @@ public static function getReferralType($cReferral)
 	}
 }
 
-?>
+ 

class/ajax/GETNewIssue.php

@@ -3,9 +3,6 @@
 
 class GETNewIssue extends AJAX {
 
-	private $theTree = array();
-	private $landlords = array();
-
     public function execute() {
 
 		// Grabs the data associated with each problem type as well as their
@@ -49,6 +46,7 @@ private function grabProblemTypes($type, $id) {
 		else if($type == 'Landlord-Tenant')
 			$type = 'LandlordTenant';
 
+		$typeArray = array();
 		foreach ($result as $r) {
 			$typeArray[$type][] = array("problem_id" => $r['id'], "name"=>$r['description'], "type"=>$r['type']);      	
         }
@@ -72,4 +70,4 @@ private function getLandlords()
 	}
 }
 
-?>
+ 

class/ajax/GETReferralBox.php

@@ -20,8 +20,6 @@ public function execute() {
         foreach( $results as $r ) { // types
         	$rTypes[] = array("referral_id" => $r['id'], "name"=>$r['name']);
         }
-
-        //$referralPicker = \PHPWS_Template::process(array("referrals"=>$rTypes), 'slc', 'ReferralPicker.tpl');
 
 	$this->addResult("referral_picker", $rTypes);    
 	}

class/ajax/GETReportCSV.php

@@ -30,4 +30,4 @@ public function execute()
     }
 }
 
-?>
+ 

class/ajax/GETStudentClientData.php

@@ -3,8 +3,6 @@
 
 class GETStudentClientData extends AJAX {
     public function execute() {
-    	$HTMLcontent = "";
-		$referral = "";
 
 		// Grabs a student object.
 		$student = ClientFactory::getClientByBannerId($_REQUEST['banner_id']);
@@ -57,4 +55,4 @@ public function execute() {
 		$this->addResult("visit", $visits);     
 	}
 }
-?>
+ 

class/ajax/IssuesFactory.php

@@ -7,20 +7,6 @@ class IssuesFactory
 	// returns the issue id
 	public static function saveIssue($issue)
 	{
-		/*
-		$db = \Database::newDB();
-		$pdo = $db->getPDO();
-
-        $values = array('id'=>$issue->getId(),
-						'problem_id'=>$issue->getProblemId(),
-						'landlord_id'=>$issue->getLandlordId());
-
-        $query = 'INSERT INTO slc_issue (id, problem_id, landlord_id)
-        		  VALUES (:id, :problem_id, :landlord_id)';
-
-	  	$sth = $pdo->prepare($query);
-		$sth->execute($values);
-		*/
 		$db = new \PHPWS_DB("slc_issue");
 		$results = $db->saveObject($issue);
 		return $results;
@@ -32,14 +18,14 @@ public static function getIssueByVisitId($vid)
 		$db = \Database::newDB();
 		$pdo = $db->getPDO();
 
-		$query = 'SELECT vii.id AS "VIIID", 
-						p.description AS "ISSUENAME", 
-						l.name as "LANDLORDNAME", 
-						i.landlord_id as "LANDLORDID", 
-						i.problem_id as "PROBLEMID", 
-						vii.i_id AS "ISSUEID", 
-						vii.counter AS "COUNTER", 
-						vii.resolve_date AS "RESOLVEDATE", 
+		$query = 'SELECT vii.id AS "VIIID",
+						p.description AS "ISSUENAME",
+						l.name as "LANDLORDNAME",
+						i.landlord_id as "LANDLORDID",
+						i.problem_id as "PROBLEMID",
+						vii.i_id AS "ISSUEID",
+						vii.counter AS "COUNTER",
+						vii.resolve_date AS "RESOLVEDATE",
 						vii.last_access AS "LASTACCESS"
 				 FROM slc_visit_issue_index as vii
 				 INNER JOIN slc_issue i ON vii.i_id=i.id
@@ -56,7 +42,7 @@ public static function getIssueByVisitId($vid)
 		{ 
         	$issue = new \slc\Issue($ir['ISSUEID']);
         	$issue->setName($ir['ISSUENAME']);
-        	$issue->setLastAccess(prettyTime($ir['LASTACCESS'])." (".prettyAccess($ir['LASTACCESS']).")");	
+        	$issue->setLastAccess(prettyTime($ir['LASTACCESS'])." (".prettyAccess($ir['LASTACCESS']).")");
 			$issue->setCounter($ir['COUNTER']);
 			$issue->setResolutionDate($ir['RESOLVEDATE']);
 			$issue->setVisitIssueId($ir['VIIID']);
@@ -74,4 +60,4 @@ public static function getIssueByVisitId($vid)
 
 }
 
-?>
+ 

class/ajax/POSTIncrementVisit.php

@@ -57,4 +57,4 @@ public function execute() {
 
 }
 
-?>
+ 

class/ajax/POSTNewVisit.php

@@ -10,7 +10,6 @@ class POSTNewVisit extends AJAX {
 	public function execute() {
 		if ( !isset($_REQUEST['banner_id']) ) {
 			$this->addResult("warning", "No Banner ID Supplied");
-//			throw new IDNotSuppliedException();
 			return;
 		}
 
@@ -60,7 +59,7 @@ public function execute() {
 
 				$i = new \slc\Issue($pid, $llid);
 				$result = IssuesFactory::saveIssue($i);
-				//$result = null;
+
 				if ($result == null)
 				{
 					$warning = "Error with issue " . $pid . " " . $llid;
@@ -94,4 +93,4 @@ public function execute() {
 	}
 }
 
-?>
+ 

class/ajax/POSTSendMail.php

@@ -34,4 +34,4 @@ public function execute(){
 	}
 }
 
-?>
+ 

class/ajax/VisitFactory.php

@@ -36,4 +36,4 @@ public static function saveVisit(&$pdo, $visit)
 	}
 }
 
-?>
+ 

class/exceptions/AJAXErrorException.php

@@ -3,4 +3,4 @@
 
 class AJAXErrorException extends \Exception {}
 
-?>
+ 

class/exceptions/AJAXNotFoundException.php

@@ -3,4 +3,4 @@
 
 class AJAXNotFoundException extends \Exception {}
 
-?>
+ 

class/exceptions/BannerNotDefinedException.php

@@ -3,4 +3,4 @@
 
 class BannerNotDefinedException extends \Exception {}
 
-?>
+ 

class/exceptions/ClientAlreadyExistsException.php

@@ -3,4 +3,4 @@
 
 class ClientAlreadyExistsException extends \Exception {}
 
-?>
+ 

class/exceptions/DatabaseException.php

@@ -3,4 +3,4 @@
 
 class DatabaseException extends \Exception {}
 
-?>
+ 

class/exceptions/IDNotSuppliedException.php

@@ -3,4 +3,4 @@
 
 class IDNotSuppliedException extends \Exception {}
 
-?>
+ 

class/exceptions/ParameterNotFoundException.php

@@ -3,4 +3,4 @@
 
 class ParameterNotFoundException extends \Exception {}
 
-?>
+ 

class/exceptions/TemplateContentNotDefinedException.php

@@ -3,4 +3,4 @@
 
 class TemplateContentNotDefinedException extends \Exception {}
 
-?>
+ 

class/exceptions/TemplateNameNotDefinedException.php

@@ -3,4 +3,4 @@
 
 class TemplateNameNotDefinedException extends \Exception {}
 
-?>
+ 

class/exceptions/TemplateNotDefinedException.php

@@ -3,4 +3,4 @@
 
 class TemplateNotDefinedException extends \Exception {}
 
-?>
+ 

class/exceptions/ViewNotFoundException.php

@@ -3,4 +3,4 @@
 
 class ViewNotFoundException extends \Exception {}
 
-?>
+ 

class/exceptions/VisitDoesNotExistException.php

@@ -3,4 +3,4 @@
 
 class VisitDoesNotExistException extends \Exception {}
 
-?>
+ 

class/indexes/VisitClient.php

@@ -37,4 +37,4 @@ public function setVId($v_id)
 	}
 }
 
-?>
+ 

class/indexes/VisitIssue.php

@@ -69,4 +69,4 @@ public function setLastAccess($last_access)
 	}
 }
 
-?>
+ 

class/reports/CsvReport.php

@@ -39,4 +39,4 @@ public function sputcsv(Array $row, $delimiter = ',', $enclosure = '"', $eol = "
         return $csv;
     }
 }
-?>
+ 

class/reports/Report.php

@@ -11,7 +11,7 @@ public function __construct($startDate, $endDate)
 	{
 		$this->startDate = $startDate;
 		$this->endDate = $endDate;
-		$this->excute();
+		$this->execute();
 	}
 
 	abstract function execute();
@@ -20,4 +20,4 @@ abstract function getHtmlView();
 
 }
 
-?>
+