-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: editor now detects phone number and launches it #970
fix: editor now detects phone number and launches it #970
Conversation
@ARYPROGRAMMER Can you add a test for the paste_command? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
==========================================
- Coverage 72.24% 72.23% -0.01%
==========================================
Files 318 318
Lines 15117 15126 +9
==========================================
+ Hits 10921 10927 +6
- Misses 4196 4199 +3 ☔ View full report in Codecov by Sentry. |
Hey, can I add a comprehensive test in another PR after this gets merged, would make it cleaner and more effective instead of adding all in one. |
added required tests as tests were specific to the added feat and can be covered easily, new coverage: 69.47% |
@LucasXu0 please review and merge |
I triggered the CI jobs and will merge the PR after all of them pass. |
let me quickly fix these lints |
@LucasXu0 can you please re-trigger ci, linting checks should pass now |
@LucasXu0 , for linting commit, can you discard/change/ignore the unorganized one. also , all important ci still pass |
just the commit message lint ci shows error since i pushed "added tests..." commit which is not of expected type , rest everything passes |
@LucasXu0 I tried changing commit name via amend, it didn't work, i think this ci would not affect much |
@LucasXu0 any updates on this? |
@ARYPROGRAMMER I can squash the PR. Thanks. |
Description
This PR addresses Issue #957, ensuring that phone numbers are detected, highlighted, and functional within the AppFlowy Editor. The issue has been resolved, and this PR closes it.
Key Improvements
Testing Details
Test Results:
Test Screenshots:
![Test Screenshot 1](https://private-user-images.githubusercontent.com/75311742/388697513-deaa1407-e796-4726-aed1-5949f4ddea26.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTY1MzMsIm5iZiI6MTczOTA1NjIzMywicGF0aCI6Ii83NTMxMTc0Mi8zODg2OTc1MTMtZGVhYTE0MDctZTc5Ni00NzI2LWFlZDEtNTk0OWY0ZGRlYTI2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDIzMTAzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUwNTY2NjQ0YjFlNzNlYWMzZGM5MzU3NTY1NzRkNzlkODlhMDE4MjBiNzliOTkxOTUxMWFhZTRkM2FlZDU5MmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.dzuyqnk0oiP2sEWHxap3MyaUx3gpfxV1i2QjLHZTf_U)
Demonstration:
Video Demonstration
How to Test
Additional Notes
Please let me know if additional modifications or improvements are required!