fix: cross blocks format not reflected on the float toolbar (#971)

* fix: cross blocks format not reflected on the float toolbar * test: cross blocks format not reflected on the float toolbar
AppFlowy-IO · Nov 25, 2024 · 6009429 · 6009429
1 parent 16a7287
commit 6009429
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/lib/src/extensions/node_extensions.dart b/lib/src/extensions/node_extensions.dart
@@ -173,7 +173,7 @@ extension NodesExtensions<T extends Node> on List<T> {
     for (var i = 0; i < nodes.length; i++) {
       final node = nodes[i];
       var delta = node.delta;
-      if (delta == null) {
+      if (delta == null || delta.isEmpty) {
         continue;
       }
 

diff --git a/test/new/extensions/node_extension_test.dart b/test/new/extensions/node_extension_test.dart
@@ -193,5 +193,43 @@ void main() async {
       });
       expect(result, false);
     });
+
+    test('2 non-empty nodes with 1 empty node', () {
+      final document = Document.blank()
+        ..addParagraph(
+          builder: (index) => Delta()
+            ..insert(
+              'Hello',
+              attributes: {AppFlowyRichTextKeys.bold: true},
+            ),
+        )
+        ..addParagraph(
+          builder: (index) => Delta(),
+        )
+        ..addParagraph(
+          builder: (index) => Delta()
+            ..insert(
+              'World',
+              attributes: {
+                AppFlowyRichTextKeys.bold: true,
+              },
+            ),
+        );
+      final editorState = EditorState(document: document);
+      final selection = Selection(
+        start: Position(path: [0], offset: 0),
+        end: Position(path: [2], offset: 5),
+      );
+      final nodes = editorState.getNodesInSelection(selection);
+      final isHighlight = nodes.allSatisfyInSelection(
+        selection,
+        (delta) =>
+            delta.isNotEmpty &&
+            delta.everyAttributes(
+              (attr) => attr[AppFlowyRichTextKeys.bold] == true,
+            ),
+      );
+      expect(isHighlight, true);
+    });
   });
 }