relax regex to ignore extra query params #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify the regex pattern for matching candidates in order to account for any extra URL query params found after `id`
|
Was experiencing difficulties and found out it was this same problem. I solved it by making the final double quote optiona, but your solution is better as it doesn't rely on greedy matching to match the whole id. |
starkayc
added a commit
to starkayc/orpheusbetter-crawler
that referenced
this pull request
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searching for candidates currently fails because the candidate search regex is strict; it assumes that there is only a single query param called
id. However, orp now returns search results whose URLs contain an additional query param. This PR fixes the problem with correctly identifying these returned search results by relaxing the regex pattern to account for the existence of additional query params.