Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dynamic routing #1

Open
wants to merge 15 commits into
base: apeswap-changes
Choose a base branch
from
Open

feat: dynamic routing #1

wants to merge 15 commits into from

Conversation

Doublo54
Copy link
Collaborator

Rename to ApeSwapMultiSwapRouter
Custom factories for routing
Factory whitelisting
AddLiquidityV2

@Doublo54 Doublo54 force-pushed the feat/dynamic-routers branch from 8d1f205 to 25a5340 Compare March 23, 2023 13:36
@Doublo54 Doublo54 force-pushed the feat/dynamic-routers branch from 25a5340 to 83f6228 Compare March 23, 2023 13:37
@DeFiFoFum
Copy link

These lens contracts are still using a single _factory it looks like:

Do you know why they went with this amountInCached pattern? Seems like an odd route to take unless there was some reason. 🤔

  • amountIn = amountInCached

DeFiFoFum
DeFiFoFum requested changes Apr 3, 2023
View reviewed changes
Copy link

@DeFiFoFum DeFiFoFum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Looking forward to integrating this.

  1. Please check the comments added during the review for refactors.
  2. I'm not able to run the tests on my end to verify they are working.

contracts/interfaces/IV2SwapRouter.sol Outdated Show resolved Hide resolved
contracts/libraries/UniswapV2Library.sol Show resolved Hide resolved
contracts/test/MockTimeSwapRouter.sol Outdated Show resolved Hide resolved
contracts/ApeSwapMultiSwapRouter.sol Outdated Show resolved Hide resolved
contracts/base/FactoryWhitelist.sol Outdated Show resolved Hide resolved
contracts/V2SwapRouter.sol Outdated Show resolved Hide resolved
contracts/base/FactoryWhitelist.sol Outdated Show resolved Hide resolved
contracts/V2SwapRouter.sol Outdated Show resolved Hide resolved
contracts/V3SwapRouter.sol Show resolved Hide resolved
README.md Show resolved Hide resolved
DeFiFoFum
DeFiFoFum approved these changes Apr 7, 2023
View reviewed changes
Copy link

@DeFiFoFum DeFiFoFum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the revision! Looking great.

I didn't review the lens contracts much btw.

@Doublo54 Doublo54 force-pushed the feat/dynamic-routers branch from d8cbf19 to 8a73356 Compare May 3, 2023 10:39
@Doublo54 Doublo54 force-pushed the feat/dynamic-routers branch from d864070 to a63fa63 Compare June 22, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeFiFoFum DeFiFoFum DeFiFoFum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doublo54 @DeFiFoFum @lint-action