Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cogwheel amulet and fix some bugs 添加齿轮护符，修复部分问题 #1602

Open
wants to merge 6 commits into
base: releases/1.21
Choose a base branch
from
Open

Add cogwheel amulet and fix some bugs 添加齿轮护符，修复部分问题 #1602

wants to merge 6 commits into from

Conversation

QiuShui1012
Copy link
Contributor

  • 添加了齿轮护符
  • 为护符添加了Curios槽位
  • 修复了护符抽奖相关的两个问题：
    • 护符抽取失败增加概率时，若消耗的物品为护符盒，现在会正常增加20%了
    • 现在会在主/副手持护符盒抽取时优先消耗背包中的图腾了
  • 将机械动力添加到了libs.versions.toml，并将依赖类型改为implementation

ZhuRuoLing
ZhuRuoLing requested changes Mar 3, 2025
View reviewed changes
src/main/resources/data/anvilcraft/curios/entities/player.json
@@ -5,7 +5,6 @@
],
"slots": [
"head",
"necklace",
"ionocraft_backpack"
"necklace"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

飘升机背包是单独槽位 请回滚更改

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前加上飘升机背包被关了pr，现在删掉了，所以是要加回来吗

src/generated/resources/data/anvilcraft/recipe/jewel_crafting/cogwheel_amulet.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

配方需要条件加载 否则物品未注册时此配方将加载失败

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这应该是WAI，加载失败会导致bug吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhuRuoLing ZhuRuoLing ZhuRuoLing requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QiuShui1012 @ZhuRuoLing