use all optional model to improve code quality / readability

[MartinBelthle]

Thanks to a home-made all_optional_model decorator (copy of the one I've created inside Antares Web) we're able to create a class that have all default values, example:

class NonOptionalSTStorageProperties(BaseModel):
    withdrawal_nominal_capacity: float = 0
    efficiency: float = 1
    initial_level: float = 0.5
    enabled: bool = True

and another class

@all_optional_model
class STStorageProperties(NonOptionalSTStorageProperties):
    pass

Thanks to this we avoid this horrible code:

self._withdrawal_nominal_capacity = check_if_none(st_storage_properties.withdrawal_nominal_capacity, 0)
self._efficiency = check_if_none(st_storage_properties.efficiency, 1)
self._initial_level = check_if_none(st_storage_properties.initial_level, 0.5)
self._enabled = check_if_none(st_storage_properties.enabled, True)

and this code (not better):

return STStorageProperties(
    group=self._group,
    injection_nominal_capacity=self._injection_nominal_capacity,
    withdrawal_nominal_capacity=self._withdrawal_nominal_capacity,
    reservoir_capacity=self._reservoir_capacity,
    efficiency=self._efficiency,
    initial_level=self._initial_level,
    initial_level_optim=self._initial_level_optim,
    enabled=self._enabled,
)

IMO it's a better way to do things but we can discuss that

[MartinBelthle]

We could rename the class NonOptionalSTStorageProperties in DefaultSTStorageProperties which could be more accurate

[Sigurd-Borge]

Great - thank you Martin.