Remove long list of if/elif, use dict #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomnes
commented
Aug 13, 2024
Comment on lines
+121
to
+138
| TYPES = { | ||
| LiteralNode: "literal", | ||
| NegationNode: "negation", | ||
| VariableNode: "variable", | ||
| ParameterNode: "parameter", | ||
| ComponentParameterNode: "comp_parameter", | ||
| ComponentVariableNode: "comp_variable", | ||
| AdditionNode: "addition", | ||
| MultiplicationNode: "multiplication", | ||
| DivisionNode: "division", | ||
| SubstractionNode: "substraction", | ||
| ComparisonNode: "comparison", | ||
| TimeOperatorNode: "time_operator", | ||
| TimeAggregatorNode: "time_aggregator", | ||
| ScenarioOperatorNode: "scenario_operator", | ||
| PortFieldNode: "port_field", | ||
| PortFieldAggregatorNode: "port_field_aggregator", | ||
| } |
There was a problem hiding this comment.
It would be better to define this object once and for all, and not evaluate it for each function call. However I don't remember how to achieve this in Python.
There was a problem hiding this comment.
Maybe using a single dispatch from functools ?
https://docs.python.org/3/library/functools.html#functools.singledispatch
There was a problem hiding this comment.
Anyway, you already did what they proposed here:
https://docs.python.org/3/faq/programming.html#how-do-i-use-strings-to-call-functions-methods
You could change the key from a string to the function itself (or a lambda), maybe ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.