review

Signed-off-by: Peter Mitri <[email protected]>
AntaresSimulatorTeam · Feb 5, 2025 · f05d736 · f05d736
1 parent 4c28b49
commit f05d736
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/sonar-project.properties b/sonar-project.properties
@@ -34,7 +34,7 @@ sonar.sourceEncoding=UTF-8
 sonar.exclusions=src/ext/**,\
 		 src/tests/**,\
 		 src/ui/**,\
-		 src/libs/antares/antlr-interface/**
+		 src/expressions/antlr-interface/**
 
 sonar.coverage.exclusions=src/ext/**,\
 			  src/tests/**,\

diff --git a/src/expressions/include/antares/expressions/visitors/InvalidNode.h b/src/expressions/include/antares/expressions/visitors/InvalidNode.h
@@ -27,6 +27,6 @@ namespace Antares::Expressions::Visitors
 class InvalidNode: public std::invalid_argument
 {
 public:
-    explicit InvalidNode(const std::string& node_name = "");
+    explicit InvalidNode(const std::string& node_name);
 };
 } // namespace Antares::Expressions::Visitors
diff --git a/src/expressions/include/antares/expressions/visitors/NodeVisitor.h b/src/expressions/include/antares/expressions/visitors/NodeVisitor.h
@@ -72,7 +72,8 @@ struct NodeVisitsProvider
     {
         std::unordered_map<std::type_index, FunctionT> nodeDispatchFunctions;
         (
-          [&nodeDispatchFunctions] {
+          [&nodeDispatchFunctions]
+          {
               nodeDispatchFunctions[typeid(NodeTypes)] = &tryVisit<R,
                                                                    NodeVisitor<R, Args...>,
                                                                    NodeTypes>;
@@ -106,7 +107,7 @@ class NodeVisitor: public IName
     {
         if (!node)
         {
-            throw InvalidNode();
+            throw InvalidNode("null");
         }
 
         const static auto nodeVisitList = NodeVisitsProvider<R, Args...>::template NodesVisitList<

diff --git a/src/expressions/visitors/InvalidNode.cpp b/src/expressions/visitors/InvalidNode.cpp
@@ -4,7 +4,7 @@ namespace Antares::Expressions::Visitors
 {
 
 InvalidNode::InvalidNode(const std::string& node_name):
-    std::invalid_argument("Antares::Expressions::Nodes Visitor: invalid node type " + node_name)
+    std::invalid_argument("Node visitor encountered an invalid node type: " + node_name)
 {
 }
 } // namespace Antares::Expressions::Visitors