feat(ini): allow custom parsers/serializers for ini options #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
MartinBelthle
requested changes
Feb 7, 2025
| ValueSerializer = Callable[[str], PrimitiveType] | ||
|
|
||
|
|
||
| def _lower_case(input: str) -> str: |
There was a problem hiding this comment.
This also exists inside the ini_reader, we could import it or put this inside the utility file
There was a problem hiding this comment.
I slightly prefer to keep it separate because it has 2 different usages (parsing and serializing)
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
MartinBelthle
previously approved these changes
Feb 10, 2025
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibility to define custom parsing and serialization for specific INI options.
Will be used for "group" attribute of clusters etc. in future work.
Also moves INI-related features to a new module dedicated to serialization and deserialization,
antarest.core.serde.(hence the many modified files)