build(all): bump pydantic and linting packages #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoPascoli
changed the title
| permissions=PermissionInfo(owner=owner.impersonator) | ||
| if owner | ||
| else PermissionInfo(public_mode=PublicMode.READ), | ||
| permissions=( |
There was a problem hiding this comment.
Why does your IDE change this ?
| @@ -81,16 +81,19 @@ def test_init__invalid_storage_id(self, recent_study: FileStudy, command_context | |||
| storage_id="?%$$", # bad name | |||
| study_version=STUDY_VERSION_8_8, | |||
| ) | |||
| assert ctx.value.errors() == [ | |||
| expected_error = [ | |||
There was a problem hiding this comment.
Couldn't you just change the url to put 2.10 ?
There was a problem hiding this comment.
I can, I feel like it is just postponing the problem. If we need the URL in the error message, I can indeed just change the url
There was a problem hiding this comment.
Indeed it's postponing for the next time we're gonna bump the lib but I think it's a small issue and it makes the test clearer IMO
MartinBelthle
changed the title
MartinBelthle
changed the title
MartinBelthle
changed the title
MartinBelthle
changed the title
MartinBelthle
previously approved these changes
Feb 6, 2025
MartinBelthle
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade pydantic to 2.9 because it introduces performances improvement. I pushed it to 2.10 because it does not contain breaking changes.
I also upgraded mypy, black and isort because why not