feat(matrix): never return empty matrix #2296
Draft
+143
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
force-pushed
the
feat/never-return-empty-matrix
branch
from
0094412 to
5229a1f
Compare
smailio
reviewed
Jan 16, 2025
| assert res.json() == {"index": [], "columns": [], "data": []} | ||
| assert res.json()["index"] == list(range(365)) | ||
| assert res.json()["columns"] == list(range(6)) | ||
| assert res.json()["data"] == default_data_matrix.tolist() | ||
|
|
There was a problem hiding this comment.
Isn't relevant to add tests for other matrices types ?
There was a problem hiding this comment.
Yes it is relevant. I'll try to add the tests i can but i won't test every case as it's boring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix [ANT-2644]
TODO: Add test cases for link matrices