Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: default port 5001 #630

Merged
merged 1 commit into from
Jan 12, 2025
Merged

doc: default port 5001 #630

merged 1 commit into from
Jan 12, 2025

Conversation

pratapvardhan
Copy link
Contributor

@pratapvardhan pratapvardhan commented Jan 9, 2025


name: Pull Request
about: since port will default to 5001 or the PORT environment variable. This PR makes the doc change to 5001 from 8000.
title: '[PR] doc: default port 5001'
labels: 'documentation'
assignees: 'jph00'


Proposed Changes
Since port will default to 5001 or the PORT environment variable. I think, it's helpful for to use 5001, instead of 8000. (which may cause some confusion with new adopters)
https://docs.fastht.ml/tutorials/by_example.html

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Copy link

gitnotebooks bot commented Jan 9, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/630

@jph00
Copy link
Contributor

jph00 commented Jan 12, 2025

Thanks :)

@jph00 jph00 merged commit c21a93f into AnswerDotAI:main Jan 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants