Avoid gcc warning about a templated packed structure

Seen in at least gcc 14. Code still seems to work ok
but not fully tested!!

CMakeLists.txt

@@ -93,6 +93,7 @@ message("-----------------------------------------------------------------------
 add_subdirectory(GUI)
 add_subdirectory(STB)
 add_subdirectory(PLT)
+add_subdirectory(USB)
 
 #-------------------------------------------------------------------------------
 

Makefile

@@ -1,5 +1,5 @@
 
-targets = native
+targets = native rpipico2 rpipico
 
 all: $(targets)
 

USB/Audio/MIDIStreaming.h

@@ -106,7 +106,12 @@ struct JackOutDescr : public Descr
 
    uint8_t jack_idx{0};
 
+#if defined(__GNUC__) && !defined(__clang__)
+}; // XXX gcc 14 is not happy with packing this structure
+   // we assume everything is still ok?
+#else
 } __attribute__((__packed__));
+#endif
 
 
 template <unsigned N>
@@ -124,7 +129,12 @@ struct CSEndPointDescr : public Descr
    uint8_t num_emb_midi_jack{N};
    uint8_t assoc_jack_id[N] = {};
 
+#if defined(__GNUC__) && !defined(__clang__)
+}; // XXX gcc 14 is not happy with packing this structure
+   // we assume everything is still ok?
+#else
 } __attribute__((__packed__));
+#endif
 
 
 struct EndPointDescr : public Descr

USB/CMakeLists.txt

@@ -0,0 +1,23 @@
+#-------------------------------------------------------------------------------
+#  Copyright (c) 2024 John D. Haughton
+# 
+#  Permission is hereby granted, free of charge, to any person obtaining a copy
+#  of this software and associated documentation files (the "Software"), to deal
+#  in the Software without restriction, including without limitation the rights
+#  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+#  copies of the Software, and to permit persons to whom the Software is
+#  furnished to do so, subject to the following conditions:
+# 
+#  The above copyright notice and this permission notice shall be included in
+#  all copies or substantial portions of the Software.
+# 
+#  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+#  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+#  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+#  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+#  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+#  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+#  SOFTWARE.
+#-------------------------------------------------------------------------------
+
+add_subdirectory(test)

USB/test/CMakeLists.txt

@@ -0,0 +1,33 @@
+#-------------------------------------------------------------------------------
+#  Copyright (c) 2025 John D. Haughton
+# 
+#  Permission is hereby granted, free of charge, to any person obtaining a copy
+#  of this software and associated documentation files (the "Software"), to deal
+#  in the Software without restriction, including without limitation the rights
+#  to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+#  copies of the Software, and to permit persons to whom the Software is
+#  furnished to do so, subject to the following conditions:
+# 
+#  The above copyright notice and this permission notice shall be included in
+#  all copies or substantial portions of the Software.
+# 
+#  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+#  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+#  FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+#  AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+#  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+#  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+#  SOFTWARE.
+#-------------------------------------------------------------------------------
+
+if(${PLT_NATIVE})
+
+   add_executable(test_USB
+                  testMain.cpp
+                  testAudio.cpp)
+
+   target_link_libraries(test_USB STB)
+
+   add_test(NAME test_USB COMMAND test_USB)
+
+endif()

USB/test/testAudio.cpp

@@ -0,0 +1,34 @@
+//------------------------------------------------------------------------------
+// Copyright (c) 2025 John D. Haughton
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+// SOFTWARE.
+//------------------------------------------------------------------------------
+
+#include "USB/Audio/MIDIStreaming.h"
+
+#include "STB/Test.h"
+
+TEST(USB_Audio, structure_sizes)
+{
+   EXPECT_EQ(size_t(7),         sizeof(USB::MS::HeaderDescr) - sizeof(USB::Descr));
+   EXPECT_EQ(size_t(6),         sizeof(USB::MS::JackInDescr) - sizeof(USB::Descr));
+   EXPECT_EQ(size_t(7 + 2 * 2), sizeof(USB::MS::JackOutDescr<2>) - sizeof(USB::Descr));
+   EXPECT_EQ(size_t(4 + 2),     sizeof(USB::MS::CSEndPointDescr<2>) - sizeof(USB::Descr));
+   EXPECT_EQ(size_t(9),         sizeof(USB::MS::EndPointDescr) - sizeof(USB::Descr));
+}

USB/test/testMain.cpp

@@ -0,0 +1,25 @@
+//------------------------------------------------------------------------------
+// Copyright (c) 2025 John D. Haughton
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+// SOFTWARE.
+//------------------------------------------------------------------------------
+
+#include "STB/Test.h"
+
+TEST_MAIN