Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the service layout #835

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

samarsajad
Copy link
Contributor

Description

Aligned the services page with the main website theme

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

servicedemo.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

GSSoC'24

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 4:45pm

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit e80f56d
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66915d8ea1fb13000794840a
😎 Deploy Preview https://deploy-preview-835--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @samarsajad! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@samarsajad
Copy link
Contributor Author

Please review my pull request @varshith257 @Anishkagupta04

@varshith257 varshith257 added gssoc level3 hard (new feature) labels Jul 12, 2024
@varshith257
Copy link
Collaborator

varshith257 commented Jul 12, 2024

@samarsajad Everything is good. Except for this few changes :

image

I think it got misaligned move Find out Little more to left

image

Here move text to upside and learn more could be down side the image in center and make sure add a div box to learnmore

@samarsajad
Copy link
Contributor Author

Alright. I'll work on it

@samarsajad
Copy link
Contributor Author

Made the chnages as requested. PTAl @varshith257 @Anishkagupta04

@varshith257
Copy link
Collaborator

@samarsajad Looks good to merge. You can also open a issue to make this page mobile responsive

@varshith257 varshith257 merged commit 026401f into Anishkagupta04:main Jul 12, 2024
8 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

@samarsajad
Copy link
Contributor Author

@samarsajad Looks good to merge. You can also open a issue to make this page mobile responsive

create the issue #845 . Please assign this to me @varshith257 @Anishkagupta04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨[Feature Request]: Re-design service page
2 participants