Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove old Gitpod configuration mechanism #80

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

AngryMaciek
Copy link
Owner

@AngryMaciek AngryMaciek commented Jan 28, 2024

Types of changes 🔧

What type of changes does your code introduce to the project?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Checklist ✅

If you're unsure about any of those below, ask explicitly.
This is simply a reminder of what needs to be checked before merging your code.

  • I have read the CONTRIBUTING.
  • I have performed a self-review of my own code.
  • Tests specified with the 'make' framework do not raise any errors.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d9d535) 100.00% compared to head (76494f4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          893       893           
=========================================
  Hits           893       893           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Dear @AngryMaciek,

It is our utmost pleasure to receive your glorious PR to our humble codebase.
You may kick back & relax for now. Our team will be with you shortly...





Fig 1. Typical GitHub repo: PR assignee & a reviewer arguing over typos.

@AngryMaciek AngryMaciek added the bug Something isn't working label Jan 28, 2024
@AngryMaciek AngryMaciek merged commit 0107c1e into master Jan 28, 2024
41 checks passed
@AngryMaciek AngryMaciek deleted the refactor branch January 28, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS ci-tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant