Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce withRegistry helper in EntityBuilder #159

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

AndreasLrx
Copy link
Owner

Description

Expose EntityBuilder._registry with const and non const getRegistry methods.
And introduce a new withRegistry helper to forward the internal registry as the first parameter to the component constructor.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a documentation update
  • I need help with writing tests

@AndreasLrx AndreasLrx added enhancement New feature or request registry Related to ecstasy registries entity Related to ecstasy entities core Core feature labels Aug 27, 2024
@AndreasLrx AndreasLrx self-assigned this Aug 27, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (249352e) to head (30bb165).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files          63       63           
  Lines        1096     1096           
  Branches      349      349           
=======================================
  Hits          907      907           
  Misses        133      133           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreasLrx AndreasLrx merged commit 42c5b14 into main Aug 27, 2024
4 checks passed
@AndreasLrx AndreasLrx deleted the feature/entity-builder-expose-registry branch August 27, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core feature enhancement New feature or request entity Related to ecstasy entities registry Related to ecstasy registries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants