Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Resource arrow operator missing const and dynamic cast #151

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

AndreasLrx
Copy link
Owner

Description

Arrow operator was missing a dynamic cast, failing implicit conversions.
And const version of arrow operator was also missing.

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Added/updated tests?

  • New tests written
  • Existing tests updated
  • Tests are not required because this is a documentation update
  • I need help with writing tests

@AndreasLrx AndreasLrx added bug Something isn't working resource Related to ecstasy resources labels Apr 29, 2024
@AndreasLrx AndreasLrx self-assigned this Apr 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.21%. Comparing base (331c583) to head (0023a5f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files          63       63           
  Lines        1090     1090           
  Branches      345      345           
=======================================
  Hits          907      907           
  Misses        127      127           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreasLrx AndreasLrx merged commit 67f3801 into main Apr 29, 2024
4 checks passed
@AndreasLrx AndreasLrx deleted the fix/resource-arrow-operator branch April 29, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resource Related to ecstasy resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants