Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167975800 Fix email duplication #210

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

leonardnjura
Copy link
Collaborator

@leonardnjura leonardnjura commented Aug 21, 2019

What does this PR do?

  • Normalizes email upon signup

Description of Task to be completed?

  • Fix email duplication

Where should the reviewer start?

Place link to file here

How should this be manually tested?

  • Clone this repo
  • Checkout bg-fix-email-duplication-167975800 branch
  • Run app
  • Goto Signup endpoint
  • Use arbitrary email to register
  • Use above email again but with modified cases
  • Expect sanity check gotcha

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

167975800

Screenshots (if appropriate)

N/A

@leonardnjura leonardnjura changed the title bug(users): Fix email duplication #167975800 Fix email duplication Aug 21, 2019
@leonardnjura leonardnjura force-pushed the bg-fix-email-duplication-167975800 branch 2 times, most recently from e54db6c to 3589ff0 Compare August 21, 2019 11:02
@leonardnjura leonardnjura added the workInProgress Not ready to merge label Aug 21, 2019
@leonardnjura leonardnjura force-pushed the bg-fix-email-duplication-167975800 branch from 3589ff0 to 2029fba Compare August 21, 2019 11:11
- normalizes email upon signup

[Delivers #167975800]
@leonardnjura leonardnjura force-pushed the bg-fix-email-duplication-167975800 branch from 2029fba to 9ce0616 Compare August 21, 2019 11:13
@leonardnjura leonardnjura added Ready Ready for review and merging and removed workInProgress Not ready to merge labels Sep 6, 2019
@leonardnjura leonardnjura requested a review from a user September 6, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready Ready for review and merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant